Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peerDependencies of ra-ui-materialui needs updating #6099

Closed
jvert opened this issue Mar 30, 2021 · 1 comment · Fixed by #6111
Closed

peerDependencies of ra-ui-materialui needs updating #6099

jvert opened this issue Mar 30, 2021 · 1 comment · Fixed by #6111
Assignees
@fzaninotto
Labels
bug

Comments

@jvert
Copy link
Contributor

jvert commented Mar 30, 2021

The ra-ui-materialui package.json has "ra-core": "^3.14.1" under devDependencies, but "ra-core": "^3.9.0" under peerDependencies. Since it depends on the new useResourceLabel hook in 3.14, I think peerDependencies also needs updating to ^3.14.

Environment

  • React-admin version: 3.14.0
  • Last version that did not exhibit the issue (if applicable): 3.13
@fzaninotto
Copy link
Member

You're right, thanks for the heads up!

@fzaninotto fzaninotto added the bug label Apr 1, 2021
@fzaninotto fzaninotto self-assigned this Apr 1, 2021
fzaninotto added a commit that referenced this issue Apr 1, 2021
@fzaninotto
Fix ra-ui-material-ui depency verion on ra-core
a6333e6 
Closes #6099
@fzaninotto fzaninotto mentioned this issue Apr 1, 2021
Merged
@djhi djhi closed this as completed in #6111 Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzaninotto fzaninotto

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ra-ui-material-ui depency verion on ra-core marmelab/react-admin
2 participants
@fzaninotto @jvert