Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go to definition doesn't work in VSCode #7811

Closed
fzaninotto opened this issue Jun 10, 2022 · 0 comments · Fixed by #7818
Closed

Go to definition doesn't work in VSCode #7811

fzaninotto opened this issue Jun 10, 2022 · 0 comments · Fixed by #7818
Labels
bug

Comments

@fzaninotto
Copy link
Member

fzaninotto commented Jun 10, 2022 •
edited
Loading

Following #7580

The "go to definition" VSCode function used to work for react-admin (at least since #6039). But in v4, we've switched from tsc to tsup, and the declarationMap directive in tsconfig.json isn't honored anymore. This seems to be a limitation of tsup (cf egoist/tsup#488), and a serious regression.

The only solution seems to go back to tsc until tsup does a better job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sourcemaps support with TS marmelab/react-admin
1 participant
@fzaninotto