Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with esbuild #6993

Merged
merged 10 commits into from
Dec 16, 2021
Merged

Build with esbuild #6993

merged 10 commits into from
Dec 16, 2021

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Dec 14, 2021

I haven't noticed any difference in the build output for the demo. I checked its bundle analysis and tree shaking seems to work fine

@djhi djhi added the WIP Work In Progress label Dec 14, 2021
@djhi djhi added this to the 4.0.0-alpha.1 milestone Dec 14, 2021
@@ -0,0 +1 @@
export * from './RichTextInput';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change as we now have a named export. However, we plan to replace this input with the tiptap version

@vercel vercel bot temporarily deployed to Preview – react-admin-storybook December 14, 2021 11:29 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin December 14, 2021 11:29 Inactive
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Dec 14, 2021
@djhi djhi requested a review from fzaninotto December 14, 2021 11:39
Copy link
Contributor

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try it and builds everything without problem, even though I don't see an important improvement in time

@fzaninotto
Copy link
Member

That's awesome, but I find the build output too verbose:

image

Could you make it shorter?

@djhi
Copy link
Collaborator Author

djhi commented Dec 15, 2021

Only completely silent = only errors

@fzaninotto
Copy link
Member

sounds good to me

@vercel vercel bot temporarily deployed to Preview – react-admin December 15, 2021 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin-storybook December 15, 2021 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin December 15, 2021 17:17 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin-storybook December 15, 2021 17:17 Inactive
@fzaninotto fzaninotto merged commit a625dc0 into next Dec 16, 2021
@fzaninotto fzaninotto deleted the esbuild branch December 16, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants