Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix <AutocompleteInput> clear button does not clear new choice #10023

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix <AutocompleteInput> clear button does not clear new choice #10023

merged 1 commit into from
Jul 19, 2024

Conversation

adguernier
Copy link
Contributor

Problem

Fixes #9993

How To Test

  1. Navigate to this story
  2. Fill the input with a choice that does not exist
  3. Click the clear button -> it should delete the new choice
  4. Fill the input again with a choice that does not exist
  5. Click the clear button -> it should now delete the new choice

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why) -> not needed
  • The documentation is up to date -> not needed

Also, please make sure to read the contributing guidelines.

@djhi djhi added this to the 5.0.5 milestone Jul 19, 2024
@djhi djhi merged commit 452b120 into master Jul 19, 2024
14 checks passed
@djhi djhi deleted the fix-autocomplete-clear-button branch July 19, 2024 14:21
@erwanMarmelab erwanMarmelab mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.5
Development

Successfully merging this pull request may close these issues.

<AutocompleteInput> clear button does not clear new choice
2 participants
@adguernier @djhi