Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter button accessibility #10204

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fix filter button accessibility #10204

merged 2 commits into from
Sep 13, 2024

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Sep 13, 2024

Problem

The FilterButton is not accessible

Solution

add menuitemcheckbox role (see https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menuitemcheckbox_role)

How To Test

Tests for FilterButton uses the role and pass

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)

@djhi djhi added the RFR Ready For Review label Sep 13, 2024
@djhi djhi changed the base branch from master to next September 13, 2024 15:56
@fzaninotto fzaninotto merged commit 0b88f6d into next Sep 13, 2024
14 checks passed
@fzaninotto fzaninotto deleted the fix-filter-button-accessibility branch September 13, 2024 16:17
@fzaninotto fzaninotto added this to the 5.2.0 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@erwanMarmelab erwanMarmelab erwanMarmelab approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djhi @fzaninotto @erwanMarmelab