Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update <Filterbutton>'s screencast #10213

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

erwanMarmelab
Copy link
Contributor

Problem

<Filterbutton>'s doc was updated but the screencast was not.

Solution

  • Record and update screencast
  • Remove webm and gif files
  • Update imports

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The documentation is up to date

@erwanMarmelab erwanMarmelab added the RFR Ready For Review label Sep 17, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with this video. It's excrutiatingly slow. Also, the example doesn't make sense. A filter "bar" on the "nested" field?? I suggest you follow the exact same scenario as the original.

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video looks good now

@fzaninotto fzaninotto merged commit 851d2d1 into master Oct 1, 2024
14 checks passed
@fzaninotto fzaninotto deleted the feat/filterbutton/Update_screencast branch October 1, 2024 09:51
@fzaninotto fzaninotto added this to the 5.2.2 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants