[Doc] Update outdated ecommerce demo video #10236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanMarmelab
commented
Sep 24, 2024
fzaninotto
requested changes
Sep 24, 2024
docs/Demos.md
Outdated
| @@ -208,7 +208,9 @@ If you want to see what react-admin is capable of, or if you want to learn from | |||
|
|
|||
| The admin of a fictional poster shop, allowing to manage sales, products, customers and reviews. Built by the core team. | |||
|
|
|||
| <div style="padding:56.25% 0 0 0;position:relative;"><iframe src="https://player.vimeo.com/video/474999017?h=4557e43b02&title=0&byline=0&portrait=0" style="position:absolute;top:0;left:0;width:100%;height:100%;" frameborder="0" allow="autoplay; fullscreen; picture-in-picture" allowfullscreen></iframe></div> | |||
| <div style="padding:56.25% 0 0 0;position:relative;"> | |||
| <iframe width="1264" height="711" src="https://www.youtube.com/embed/gW6BvodBIzE" title="react admin e commerce demo" style="position:absolute;top:0;left:0;width:100%;height:100%;" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" allowfullscreen></iframe> | |||
There was a problem hiding this comment.
use the nocookie domain (see other youtube embeds)
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
I don't agree. Those Vimeo videos refers to other videos and not this one (cf all videos we have) |
You're right, but the problem is even worse: the other video is a demo of react-admin v2, so it's even more outdated! |
fzaninotto
approved these changes
Sep 24, 2024
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Vimeo will delete our e-commerce video.
Solution
Change publication platform for YouTube