Access control: pessimistic rendering in CRUD views #10258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Oct 4, 2024
| } | ||
|
|
||
| return ( | ||
| <OptionalResourceContextProvider value={controllerProps.resource}> |
There was a problem hiding this comment.
Suggested change
| <OptionalResourceContextProvider value={controllerProps.resource}> | |
| <OptionalResourceContextProvider value={props.resource}> |
Otherwise it's a BC. Same for other controllers.
There was a problem hiding this comment.
No because the controller already handles it
| @@ -81,6 +82,7 @@ export const Create = < | |||
| disableAuthentication={disableAuthentication} | |||
| hasEdit={hasEdit} | |||
| hasShow={hasShow} | |||
| loading={defaultLoading} | |||
There was a problem hiding this comment.
<Create> should allow overriding the loading component. Same for the others.
Yes, by wrapping user provided dashboard in another component |
fzaninotto
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All CRUD views currently starts to render optimistically even though authentication and optionally authorization checks are pending. This is a security issue.
Solution
Make sure the base components for all CRUD views verify that no auth checks are pending before rendering.
Introduce a loading prop accepting a ReactNode on those components that is displayed while auth checks are pending.
How To Test
Describe the steps required to test the changes
Additional Checks
masterfor a bugfix, ornextfor a feature