Fix DateInput messes up dates in some timezones #10299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
reviewed
Oct 24, 2024
slax57
requested changes
Oct 25, 2024
fzaninotto
approved these changes
Oct 28, 2024
fzaninotto
reviewed
Oct 28, 2024
| @@ -202,38 +205,65 @@ export type DateInputProps = CommonInputProps & | |||
| Omit<TextFieldProps, 'helperText' | 'label'>; | |||
|
|
|||
| /** | |||
| * Convert Date object to String | |||
| * Convert Date object to String, ignoring the timezone. | |||
| * | |||
| * @param {Date} value value to convert | |||
| * @returns {String} A standardized date (yyyy-MM-dd), to be passed to an <input type="date" /> | |||
| */ | |||
| const convertDateToString = (value: Date) => { | |||
There was a problem hiding this comment.
We still need this change for cases where the initial value is a non-standard date string (e.g. 02/02/2001)
fzaninotto
added a commit
that referenced
this pull request
Oct 28, 2024
## Problem The changes introduced in #10299 leads to a regression when the field value is an ISO string or date. The idea of that change was that if the value contains a date, react-admin should always display that date. This is often not what users want, because a date entered in a US browser than stored in GMT then displayed again will have shifted. Besides, this is not required to fix #10197. The fix in #10299 is the removal of the call to `parse` in `onChange` (in fact, `parse` used to be called twice). ## Solution Do not strip the timezone data, whether the field value is a string or a date.
quentin-decre
pushed a commit
to quentin-decre/react-admin
that referenced
this pull request
Nov 13, 2024
## Problem The changes introduced in marmelab#10299 leads to a regression when the field value is an ISO string or date. The idea of that change was that if the value contains a date, react-admin should always display that date. This is often not what users want, because a date entered in a US browser than stored in GMT then displayed again will have shifted. Besides, this is not required to fix marmelab#10197. The fix in marmelab#10299 is the removal of the call to `parse` in `onChange` (in fact, `parse` used to be called twice). ## Solution Do not strip the timezone data, whether the field value is a string or a date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #10197
Solution
We were trying to convert the input value into a
Date. However, when passing a partial date (such as the html input valueyyyy-MM-dd) toDate, it assumes the UTC timezone. When stringified again, this UTC date might be different than the one entered by users because of their timezone.How To Test
Additional Checks
masterfor a bugfix, ornextfor a feature