Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add material-ui dependence #104

Closed
wants to merge 1 commit into from
Closed

Conversation

kpitn
Copy link

@kpitn kpitn commented Oct 23, 2016

No description provided.

@kpitn kpitn changed the title Add material-ui dependence [DOC] Add material-ui dependence Oct 23, 2016
@fzaninotto
Copy link
Member

It's only a problem if you use npm 2 isn't it?

@kpitn
Copy link
Author

kpitn commented Oct 23, 2016

I don't know if it's related, but I'm usingnpm 2.15.8

@jpetitcolas
Copy link
Contributor

Which version are you using? Because material-ui is already listed as dependencies: https://github.com/marmelab/admin-on-rest/blob/master/package.json#L57

@fzaninotto
Copy link
Member

But the tutorial only asks to install admin-on-rest. With npm 2, admin-on-rest's dependencies (including material-ui) are under node_modules/admin-on-rest/node_modules and can't be found by a simple import.

Npm 2 is outdated, and we don't want to spend time supporting it. Instead of making the documentation harder to follow, I suggest that we add node 5 (with npm 3) as required dependency of admin-on-rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants