Skip to content

Add timeout prop to loading components #10836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Jul 11, 2025

Problem

Some loading components have a one second hard-coded wait before rendering

Solution

I've simply added a timeout optional prop, default to 1 second
Fixes #10835

Additional Checks

  • The PR targets next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

@fzaninotto
Copy link
Member

Thanks! Would you mind updating the doc to allow users to discover this setting?

@WiXSL
Copy link
Contributor Author

WiXSL commented Jul 16, 2025

Thanks! Would you mind updating the doc to allow users to discover this setting?

Sure, but where exactly do I add the docs? I can't find a good place.

@fzaninotto
Copy link
Member

Good point! Which leads me to the question: How can anyone use these new props? DataTable and SimpleList don't expose their loading component.

@WiXSL
Copy link
Contributor Author

WiXSL commented Jul 16, 2025

Good point! Which leads me to the question: How can anyone use these new props? DataTable and SimpleList don't expose their loading component.

Mmm, you are right!
It is true that they don't expose these components, but they get exported.
I already did this with the Loading component to be able to re-use it.

Maybe the best solution is to add a loading prop to SimpleList, DataTable, and Datagrid components to be able to expose the loading component (in another PR) and merge this one as is.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants