[RFR] Pass the current record to rowClick #2625
Merged
+70
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kmaschta
suggested changes
Dec 5, 2018
fzaninotto
requested changes
Dec 5, 2018
| @@ -96,7 +104,7 @@ const PostList = withStyles(styles)(({ classes, ...props }) => ( | |||
| /> | |||
| } | |||
| medium={ | |||
| <Datagrid> | |||
| <Datagrid rowClick={rowClick}> | |||
There was a problem hiding this comment.
the PostList has an Edit and Show button, it doesn't make sense to use rowClick here.
There was a problem hiding this comment.
It's used for the e2e tests
There was a problem hiding this comment.
And we should definitely rename this sample
There was a problem hiding this comment.
Having a Edit button in addition of a row click doesn't bother me at all.
Quite the opposite!
fzaninotto
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.