[RFR] FileInput - Display validation errors #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
changed the title
Also fixed warnings from Labeled
djhi
force-pushed
the
file-input-validation
branch
from
c9017a3 to
72743f5
Compare
fzaninotto
approved these changes
Dec 13, 2018
djhi
changed the title
fzaninotto
reviewed
Dec 13, 2018
| @@ -70,7 +70,7 @@ const PostEdit = props => ( | |||
| { id: 42, name: 'Sean Phonee' }, | |||
| ]} | |||
| /> | |||
| <ImageInput multiple source="pictures" accept="image/*" validate={required()}> | |||
There was a problem hiding this comment.
I don't understand that change. How are you supposed to test it?
There was a problem hiding this comment.
Well I added it to test manually in the first place but ok, I'll write tests for it 😢
There was a problem hiding this comment.
no no no, it will get really tedious if the form doesn't accept posts without files. It's ok like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed warnings from Labeled
Fixes #825