fix(resourcesRoutes): Added prop exact to all resources routes #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
approved these changes
Mar 20, 2019
|
Well, well! E2E tests are failing, especially on with custom pages. |
kopax
commented
Mar 21, 2019
There was a problem hiding this comment.
@djhi I have investigated and I found out the fix you suggested was not producing the expected result.
Adding exact in here will do it on one route:
<Route path={`/${child.props.name}`} />
There is no props spread on these routes so there's no way to pass it from any parent. I suggest to restore the 1st fix. It directly set the exact props to true to each resource route.
Edit
See comment here.
|
As seen in #2910, we won't address that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3021
Fix #2910