Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Turn data generator for demo into a public repository #3096

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Apr 4, 2019

Rationale

  • When learning react-admin, developers often need a fake API. jsonplaceholder isn't perfect (it doesn't accept mutations), so developers use JSONServer or json-graphql-server, but they need data.
  • The demo doesn't run on CodeSandbox as is because of the dependency to an internal package. Having the demo run in CodeSandbox would ease bug reports
  • Who doesn't need fake data?

@@ -1,7 +1,9 @@
{
"name": "data-generator",
"name": "data-generator-retail",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name data-generator is already taken

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ra-data-generator ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, we may publish data generators for blogs, social network, etc in the future. Also, it's in react-admin for now, but honestly nothing forbids that it lives on its own. It's just more convenient to keep it here for now.

@djhi djhi merged commit 82aea2a into master Apr 4, 2019
@djhi djhi added this to the 2.8.5 milestone Apr 4, 2019
@djhi djhi deleted the data-generator-retail branch April 4, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants