-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the default app weight by removing the image background on the Login screen #4342
Conversation
If I'm not mistaken, that's a breaking change: people having defined a custom image for the background will lose it. Can you make the change backwards compatible? |
It seems to me it's even worse since the default prop has been removed from Also only the demo has been changed, why not using this for the framework? Nice change btw 🙂 |
I just removed the default value for the background image. Only people that specified no backround image will have a white background. Which can be considered a breaking change. I can split the PR.
|
6113d8e
to
7cc6db3
Compare
Well totally changed the pr to only replace the unspalsh default image with a gradient in the Login component. |
this needs to be done on the |
@@ -44,6 +44,8 @@ const useStyles = makeStyles( | |||
justifyContent: 'flex-start', | |||
backgroundRepeat: 'no-repeat', | |||
backgroundSize: 'cover', | |||
backgroundImage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggested alternative: 'radial-gradient(circle at 50% 14em, #313264 0%, #00023b 60%, #00023b 100%)'
7cc6db3
to
22e9afc
Compare
Replace default unsplash image for Login component by a simple gradient.
Demo login is unchanged.
Preview: