Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Add linkType to ReferenceField #490

Merged
merged 6 commits into from
Mar 23, 2017
Merged

[RFR] Add linkType to ReferenceField #490

merged 6 commits into from
Mar 23, 2017

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Mar 20, 2017

Supersedes #486 by fixing coding standards and documentation, and adding tests.

Fixes #247.

leesei and others added 4 commits March 20, 2017 22:42
 Changes to be committed:
	modified:   docs/Fields.md
	modified:   src/mui/field/ReferenceField.js
@leesei
Copy link
Contributor

leesei commented Mar 21, 2017

If we are to support boolean linkType, should line 65 change to

if (linkType === 'edit' || linkType === true) {

@fzaninotto
Copy link
Member Author

@leesei nice to have, but good enough as is.

* Set the linkType prop to "show" to link to the <Show> page instead.
*
* @example
* <ReferenceField label="User" source="userId" reference="users" linkType="edit">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/edit/show/

@fzaninotto
Copy link
Member Author

Code review applied

@michaeI
Copy link

michaeI commented Nov 8, 2022

What about referenceArrayField, how to disable link there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants