Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Added Inputs and Fields CSS Api documentation #5346

Merged
merged 19 commits into from
Oct 8, 2020
Merged

[Doc] Added Inputs and Fields CSS Api documentation #5346

merged 19 commits into from
Oct 8, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Oct 3, 2020

No description provided.

@WiXSL WiXSL changed the title [Doc] Added Inputs and Fields CSS api documentation [Doc] Added Inputs and Fields CSS Api documentation Oct 3, 2020
fzaninotto
fzaninotto requested changes Oct 5, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, it will really help developers. Looking forward to merging this one.

Could you please use the suggested wording for all fields / inputs and revert the reformatting of tables?

@WiXSL WiXSL requested a review from fzaninotto October 5, 2020 17:44
@WiXSL
Copy link
Contributor Author

WiXSL commented Oct 7, 2020 •
edited
Loading

I've reverted the formatting of props table. Sorry I didn't get the problem was the | formatting.

@fzaninotto fzaninotto merged commit 703be28 into marmelab:master Oct 8, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.9.3 milestone Oct 8, 2020
@WiXSL WiXSL deleted the docs-css-api branch October 8, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@WiXSL @fzaninotto