Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non null id types handling #5402

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Fix non null id types handling #5402

merged 1 commit into from
Oct 20, 2020

Conversation

EmrysMyrddin
Copy link
Contributor

If the id field of an entity has a non null type like Int!, it cannot be edited with the Edit screen.

The problem was the castType function not handling types with NON_NULL kind which wraps the real type under a ofType property.

closes #5400

djhi
djhi approved these changes Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 3.9.5 milestone Oct 20, 2020
@djhi djhi merged commit 40d478f into marmelab:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.5
Development

Successfully merging this pull request may close these issues.

Edit screen doesn't work with ra-data-graphql-simple if resource id is of type Int!
2 participants
@EmrysMyrddin @djhi