Fix typos in Theming doc #5546
Merged
Fix typos in Theming doc #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- typo - no error page in example, so I removed the mention in the text - I added a comment in the text itself, another occurrence of something mentioned in text that doesn't appear in code. So I guess you have some fixing to do before merging.
fzaninotto
requested changes
Nov 18, 2020
docs/Theming.md
Outdated
| @@ -387,7 +387,7 @@ const App = () => ( | |||
| ); | |||
| ``` | |||
|
|
|||
| Your custom layout can extend the default `<Layout>` component if you only want to override the sidebar, the appBar, the menu, the notification component, or the error page. For instance: | |||
| Your custom layout can extend the default `<Layout>` component if you only want to override the sidebar, the appBar, the menu or the notification component. For instance: | |||
There was a problem hiding this comment.
Even though the example doesn't show how to change the error page, the layout has this role, so you should revert that change.
docs/Theming.md
Outdated
| @@ -890,7 +890,7 @@ const App = () => ( | |||
|
|
|||
| The `MenuItemLink` component make use of the React Router [NavLink](https://reacttraining.com/react-router/web/api/NavLink) component, hence allowing to customize its style when it targets the current page. | |||
|
|
|||
| If the default active style does not suit your tastes, you can override it by passing your own `classes`: | |||
| If the default active style does not suit your tastes, you can override it by passing your own `classes`: // the code below doesn't use the `classes` prop | |||
There was a problem hiding this comment.
The code below, introduced in 8fcd609, doesn't teach anything about classes and doesn't show anything more than the previous snippet. It and should be removed, together with the entire sentence "if the default active style...".
fzaninotto
approved these changes
Nov 18, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I guess you have some fixing to do before merging.