Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contentClassName prop to SimpleForm component #5697

Closed
wants to merge 2 commits into from
Closed

Add contentClassName prop to SimpleForm component #5697

wants to merge 2 commits into from

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Dec 21, 2020

Implements #5696

@fzaninotto
Copy link
Member

I'm not sure it's a good idea. I'd prefer if SimpleForm accepted a component prop allowing to replace the CardContentInner element.

Also, this is a new feature, so please PR against next.

@fzaninotto fzaninotto mentioned this pull request Dec 21, 2020
Closed
@WiXSL WiXSL closed this Dec 21, 2020
@WiXSL
Copy link
Contributor Author

WiXSL commented Dec 21, 2020

Changed for #5703

@WiXSL WiXSL deleted the add-simpleform-contentclassname branch December 21, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WiXSL @fzaninotto