Fix "Please login to continue" notification remains after login

packages/ra-core/src/actions/notificationActions.ts

@@ -53,3 +53,13 @@ export interface HideNotificationAction {
 export const hideNotification = (): HideNotificationAction => ({
     type: HIDE_NOTIFICATION,
 });
+
+export const RESET_NOTIFICATION = 'RA/RESET_NOTIFICATION';
+
+export interface ResetNotificationAction {
+    readonly type: typeof RESET_NOTIFICATION;
+}
+
+export const resetNotification = (): ResetNotificationAction => ({
+    type: RESET_NOTIFICATION,
+});

packages/ra-core/src/auth/useLogin.ts

@@ -1,7 +1,9 @@
 import { useCallback } from 'react';
+import { useLocation, useHistory } from 'react-router-dom';
+import { useDispatch } from 'react-redux';
 
 import useAuthProvider, { defaultAuthParams } from './useAuthProvider';
-import { useLocation, useHistory } from 'react-router-dom';
+import { resetNotification } from '../actions/notificationActions';
 
 /**
  * Get a callback for calling the authProvider.login() method
@@ -31,26 +33,29 @@ const useLogin = (): Login => {
     const location = useLocation();
     const locationState = location.state as any;
     const history = useHistory();
+    const dispatch = useDispatch();
     const nextPathName = locationState && locationState.nextPathname;
 
     const login = useCallback(
         (params: any = {}, pathName) =>
             authProvider.login(params).then(ret => {
+                dispatch(resetNotification());
                 const redirectUrl = pathName
                     ? pathName
                     : nextPathName || defaultAuthParams.afterLoginUrl;
                 history.push(redirectUrl);
                 return ret;
             }),
-        [authProvider, history, nextPathName]
+        [authProvider, history, nextPathName, dispatch]
     );
 
     const loginWithoutProvider = useCallback(
         (_, __) => {
+            dispatch(resetNotification());
             history.push(defaultAuthParams.afterLoginUrl);
             return Promise.resolve();
         },
-        [history]
+        [history, dispatch]
     );
 
     return authProvider ? login : loginWithoutProvider;

packages/ra-core/src/reducer/admin/notifications.ts

@@ -4,20 +4,25 @@ import {
     ShowNotificationAction,
     HIDE_NOTIFICATION,
     HideNotificationAction,
+    RESET_NOTIFICATION,
+    ResetNotificationAction,
     NotificationPayload,
 } from '../../actions/notificationActions';
 import { UNDO, UndoAction } from '../../actions/undoActions';
 
 type ActionTypes =
     | ShowNotificationAction
     | HideNotificationAction
+    | ResetNotificationAction
     | UndoAction
     | { type: 'OTHER_TYPE' };
 
 type State = NotificationPayload[];
 
+const initialState = [];
+
 const notificationsReducer: Reducer<State> = (
-    previousState = [],
+    previousState = initialState,
     action: ActionTypes
 ) => {
     switch (action.type) {
@@ -26,6 +31,8 @@ const notificationsReducer: Reducer<State> = (
         case HIDE_NOTIFICATION:
         case UNDO:
             return previousState.slice(1);
+        case RESET_NOTIFICATION:
+            return initialState;
         default:
             return previousState;
     }