Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onSuccess called without payload on undoable actions #5828

Closed
wants to merge 2 commits into from
Closed

Fix onSuccess called without payload on undoable actions #5828

wants to merge 2 commits into from

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jan 28, 2021

Fixes #5819

@djhi djhi added the RFR Ready For Review label Jan 28, 2021
@djhi djhi added this to the 3.12 milestone Jan 28, 2021
@fzaninotto
Copy link
Member

I don't think that's correct. You're calling the success side effect with the request payload, not the response payload.

Since we can't return the success payload for optimistic calls, we should document that, in this case, the payload is empty.

@fzaninotto fzaninotto removed this from the 3.12 milestone Jan 28, 2021
@fzaninotto
Copy link
Member

I'll update the documentation instead.

@fzaninotto fzaninotto closed this Feb 2, 2021
@fzaninotto fzaninotto deleted the fix-optimistic-onsuccess branch April 4, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit onSuccess prop doesn't work correctly
2 participants
@djhi @fzaninotto