[RFR] Added isRowExpandable prop to Datagrid component #5941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiXSL
changed the title
djhi
requested changes
Feb 22, 2021
|
Please ignore the previous comment except for the test. |
fzaninotto
requested changes
Feb 22, 2021
There was a problem hiding this comment.
We're removing props injection little by little, and replace them with contexts. I think this is a good occasion to introduce a DatagridContext, which will contain only the isRowExpandable function for a start. That way, you don't need to update the underlying components to sanitize the prop.
djhi
requested changes
Feb 23, 2021
packages/ra-ui-materialui/src/list/datagrid/useDatagridContext.ts
Outdated
Show resolved
Hide resolved
djhi
approved these changes
Feb 23, 2021
fzaninotto
requested changes
Feb 24, 2021
packages/ra-ui-materialui/src/list/datagrid/DatagridRow.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/datagrid/useDatagridContext.ts
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/datagrid/useDatagridContext.ts
Outdated
Show resolved
Hide resolved
…o DatagridBody component
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
WiXSL
force-pushed
the
add-isrowexpandable
branch
from
7b40601 to
1837d95
Compare
fzaninotto
requested changes
Feb 26, 2021
packages/ra-ui-materialui/src/list/datagrid/DatagridRow.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/datagrid/useDatagridContext.ts
Outdated
Show resolved
Hide resolved
fzaninotto
approved these changes
Feb 26, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #5888