Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/redirect cant catch search params #6009

Closed

Conversation

vctqs1
Copy link

@vctqs1 vctqs1 commented Mar 7, 2021

Since we manually add state: { _scrollToTop: true }. history cannot catch search params

@vctqs1 vctqs1 marked this pull request as ready for review March 7, 2021 03:16
@fzaninotto
Copy link
Member

Hi, and thanks for your patch. I don't understand what it fixes though. Can you pleas describe what you're trying to achieve and what happens instead?

@vctqs1
Copy link
Author

vctqs1 commented Mar 8, 2021

Hi, and thanks for your patch. I don't understand what it fixes though. Can you pleas describe what you're trying to achieve and what happens instead?

image

I tried to redirect to URL /chapters/:id?parentId=:parentID, But router cannot catch search params. Router understand params id about id and search params: id: "fa93d683-823e-4716-b1f1-54e791f4dc7d?parentId=ee8431
cc: @fzaninotto

@vctqs1
Copy link
Author

vctqs1 commented Mar 9, 2021

@fzaninotto could you help check again?

My project's block at this :((

@fzaninotto
Copy link
Member

I still don't understand. Could you try again and include the code you're writing and that doesn't work?

@hieusmiths
Copy link
Contributor

@fzaninotto Hi, I also have this problem.

I have but after edit success the location is "/any" I need keeping the query params.

Thanks

fzaninotto added a commit that referenced this pull request Apr 9, 2021
@fzaninotto
Copy link
Member

Superseded by #6145

@fzaninotto fzaninotto closed this Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants