Bugfix: Don't crash when validating inputs in Array #6133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, we might have validators on the ArrayInput itself as well, such as requiring at least X elements. We must find a way to include the errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6128
Looks like the problem was brought on with this commit: 9e547eb
The helperText treated the child input's error as a top level error. I think this threw an error because errors inside of Array inputs take the shape of their children, wheras
InputHelperTextexpected anerror message as a stringI've kept the helperText logic in, but removed any of the logic involving the errors. I don't think it's necessary considering that the children display their respective error messages