Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Notification component undo color #6189

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Fix Notification component undo color #6189

merged 2 commits into from
Apr 19, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Apr 19, 2021

Fixes #6173

@WiXSL WiXSL changed the title Fix notification undo Fix Notification component undo color Apr 19, 2021
@djhi
Copy link
Collaborator

djhi commented Apr 19, 2021

Thanks!

@djhi djhi added this to the 3.14.4 milestone Apr 19, 2021
@djhi djhi merged commit 3b84e6e into marmelab:master Apr 19, 2021
@WiXSL WiXSL deleted the fix-notification-undo branch April 19, 2021 14:04
@fzaninotto
Copy link
Member

This has changed the default color, I'm -1 for this.

image

As I need to release a new bugfix version today. I'll revert this change. Feel free to reopen a new PR to offer a fine-grained undo color.

@fzaninotto fzaninotto mentioned this pull request Apr 19, 2021
Merged
@fzaninotto fzaninotto removed this from the 3.14.4 milestone Apr 19, 2021
@fzaninotto fzaninotto mentioned this pull request Apr 19, 2021
Closed
@WiXSL WiXSL mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undo link color on success notification
3 participants
@WiXSL @djhi @fzaninotto