Fix hideFilter called repeatedly only registers the last call #6226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Apr 29, 2021
| @@ -229,38 +240,18 @@ const useListParams = ({ | |||
| ); | |||
|
|
|||
| const hideFilter = useCallback((filterName: string) => { | |||
| // we don't use lodash.set() for displayed filters | |||
There was a problem hiding this comment.
I moved the logic to the queryReducer for easier testability, but that has no effect on the bug.
fzaninotto
commented
Apr 29, 2021
| }); | ||
| }, requestSignature); // eslint-disable-line react-hooks/exhaustive-deps | ||
|
|
||
| const showFilter = useCallback((filterName: string, defaultValue: any) => { | ||
| // we don't use lodash.set() for displayed filters |
There was a problem hiding this comment.
Same, this change is just cosmetic
fzaninotto
commented
Apr 29, 2021
| @@ -163,21 +164,31 @@ const useListParams = ({ | |||
| }, []); // eslint-disable-line | |||
|
|
|||
| const changeParams = useCallback(action => { | |||
There was a problem hiding this comment.
Here is the fix: since changeParams can be called several times in the same tick, we keep the result if the reducer locally so that we can start from it if another call comes immediately after. And we change the location (or the local state) only at the next tick, when all the sync changes were applied.
fzaninotto
commented
Apr 30, 2021
djhi
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6055