Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add optional labelFn prop to SimpleFormIterator #6292

Closed
wants to merge 1 commit into from
Closed

add optional labelFn prop to SimpleFormIterator #6292

wants to merge 1 commit into from

Conversation

iamstiil
Copy link
Contributor

No description provided.

djhi
djhi reviewed May 20, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please describe the usecase?

@iamstiil
Copy link
Contributor Author

I created a custom input, with nested iterators. I would like to update the label in the nested iterators to 1.1, 1.2, etc. so that I can differentiate between 1.3 and 2.3 for example.

djhi
djhi requested changes May 21, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add tests and update the documentation?

@iamstiil
Copy link
Contributor Author

Sure 👍

@iamstiil iamstiil closed this May 21, 2021
@iamstiil iamstiil deleted the patch-1 branch May 21, 2021 09:25
This was referenced May 21, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamstiil @djhi