Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BC Break] Change setSort signature to make it consistent acrosse components #7065

Merged
merged 3 commits into from
Jan 10, 2022
Merged

[BC Break] Change setSort signature to make it consistent acrosse components #7065

merged 3 commits into from
Jan 10, 2022

Conversation

fzaninotto
Copy link
Member

  • Remove deprecated sort prop in DatagridHeaderCelle
  • Make setSort() signature consistent across all components
  • Add upgrade instructions

Closes #5096

@fzaninotto fzaninotto added the RFR Ready For Review label Jan 10, 2022
@fzaninotto fzaninotto added this to the 4.0.0-alpha.2 milestone Jan 10, 2022
@fzaninotto fzaninotto mentioned this pull request Jan 10, 2022
Closed
@vercel vercel bot temporarily deployed to Preview – react-admin January 10, 2022 16:07 Inactive
@djhi djhi merged commit dc1c6dd into next Jan 10, 2022
@djhi djhi deleted the Fix-data-sort-in-datagrid-header branch January 10, 2022 16:55
@WiXSL WiXSL mentioned this pull request Feb 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @djhi