Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC Break] React Hook Form #7087

Merged
merged 122 commits into from
Jan 26, 2022
Merged

[BC Break] React Hook Form #7087

merged 122 commits into from
Jan 26, 2022

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jan 14, 2022

Supersedes #6730

  • Migrate FormWithRedirect
  • Migrate useInput
  • Migrate form groups
  • Migrate forms
  • Migrate inputs
  • Reintroduce form level validation
  • Fix warnings in tests
  • Fix examples & demos
  • Update documentation
  • Update upgrade guide

@vercel vercel bot temporarily deployed to Preview – react-admin January 14, 2022 22:30 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 14, 2022 22:37 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 14, 2022 22:45 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 14, 2022 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 16, 2022 17:21 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 16, 2022 18:08 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 16, 2022 18:23 Inactive
@fzaninotto fzaninotto mentioned this pull request Jan 16, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin January 16, 2022 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 17, 2022 10:24 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 17, 2022 10:50 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 17, 2022 11:28 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 17, 2022 12:56 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin January 17, 2022 12:59 Inactive
@fzaninotto
Copy link
Member

@WiXSL the problems with the record context aren't linked to this PR, so we won't deal with them in ths PR. Would you mind opening an issue with them so we don't forget them?

Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AWESOME!!! 💯 👍 🎉 🦘

Thanks @djhi for this tremendous work.

@WiXSL
Copy link
Contributor

WiXSL commented Jan 26, 2022

@WiXSL the problems with the record context aren't linked to this PR, so we won't deal with them in ths PR. Would you mind opening an issue with them so we don't forget them?

Done #7145

@WiXSL
Copy link
Contributor

WiXSL commented Jan 26, 2022

Great! We have react-hooks-form working. Thank you @djhi !!! 🙃 ❤️‍🔥

@fzaninotto
Copy link
Member

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

EPIC PR

@anthonycmain
Copy link
Contributor

Out of interest why is this a breaking change prior to v4?

@djhi
Copy link
Collaborator Author

djhi commented Jan 26, 2022

It's for v4 (that's the next branch)

@anthonycmain
Copy link
Contributor

It's for v4 (that's the next branch)

Oh the Tweet I read said "This was the last big breaking change before V4" so I assume that mean v3.X

@afilp
Copy link
Contributor

afilp commented Jan 31, 2022

@djhi
Hello, does this affect the creation of custom inputs, because I get an error when I replaced
import { Field } from 'react-final-form';
with
import { Field } from 'react-hook-form';

This is the error I am getting:

ERROR in ./src/helpers/OurDateInput.js 146:30-35

export 'Field' (imported as 'Field') was not found in 'react-hook-form' (possible exports: Controller, FormProvider, appendErrors, get, set, useController, useFieldArray, useForm, useFormContext, useFormState, useWatch)

I did not find something different in UPGRADE doc or other docs on how to create a custom input field. Thanks!

@fzaninotto
Copy link
Member

@afilp indeed, it changes the syntax of custom inputs. We've updated the Inputs.md section about "Writing Your Own Input Component", but we've forgotten to add a diff in the README. We'll fix that soon.

@afilp
Copy link
Contributor

afilp commented Feb 1, 2022

@fzaninotto Thank you!

@erikras
Copy link
Contributor

erikras commented Apr 20, 2022

Thank you to this project for providing an awful lot of downloads and users to React Final Form. As the [lapsed] maintainer of said library, I'm both sad and happy to see you go. ❤️ 👋

@djhi
Copy link
Collaborator Author

djhi commented Apr 20, 2022

It wasn't an easy decision. Thank you for redux-form, final-form and centered! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants