fix: initialValue prop not used when input value is null #7133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiXSL
suggested changes
Jan 24, 2022
WiXSL
approved these changes
Jan 24, 2022
|
@WiXSL I've just found out how to test it with the examples/simple project. Maybe wait with review untill I confirmed it is working as expected there. |
|
@WiXSL Yep, I can confirm this is now working as expected! |
WiXSL
suggested changes
Jan 24, 2022
WiXSL
approved these changes
Jan 25, 2022
|
@thdk, So after discussion the solution is to fix the documentation, not the inputs. |
|
Superseded by #7139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7132
I have replaced the lodash get method so that it is easier for maintainers / contributors to see what happens.
Lodash
getwill not use the default value when the result isnull. While we need the initialValue to be returned for both null and undefined values as written in react admin docs. See docs for, the DateInput component.