Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid cloning element for optionText #7215

Merged
merged 8 commits into from
Feb 10, 2022
Merged

Avoid cloning element for optionText #7215

merged 8 commits into from
Feb 10, 2022

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Feb 9, 2022

No description provided.

@djhi djhi added the RFR Ready For Review label Feb 9, 2022
@djhi djhi added this to the 4.0.0-alpha.3 milestone Feb 9, 2022
@djhi djhi added WIP Work In Progress and removed RFR Ready For Review labels Feb 9, 2022
@djhi djhi force-pushed the avoid-cloning-optionText branch from cf93765 to 4e2e55c Compare February 9, 2022 15:55
@vercel vercel bot temporarily deployed to Preview – react-admin February 9, 2022 15:55 Inactive
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Feb 9, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin February 9, 2022 16:10 Inactive
@djhi @WiXSL
Apply suggestions from code review
10c8746 
Co-authored-by: Aníbal Svarcas <WiXSL@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – react-admin February 10, 2022 12:51 Inactive
@djhi @WiXSL
Update packages/ra-ui-materialui/src/input/SelectInput.tsx
5175d12 
Co-authored-by: Aníbal Svarcas <WiXSL@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – react-admin February 10, 2022 13:00 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin February 10, 2022 13:02 Inactive
WiXSL
WiXSL suggested changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutocompleteArrayInput.tsx also has the same JsDocs and needs to be changed.

`optionText` also accepts a React Element, that will be cloned and receive
the related choice as the `record` prop. You can use Field components there.
Note that you must also specify the `matchSuggestion` prop

@vercel vercel bot temporarily deployed to Preview – react-admin February 10, 2022 13:13 Inactive
@fzaninotto
Copy link
Member

Needs rebase

@vercel vercel bot temporarily deployed to Preview – react-admin February 10, 2022 15:09 Inactive
@fzaninotto fzaninotto merged commit 66197e9 into next Feb 10, 2022
@fzaninotto fzaninotto deleted the avoid-cloning-optionText branch February 10, 2022 16:11
@fzaninotto fzaninotto mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiXSL WiXSL WiXSL requested changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@djhi @fzaninotto @WiXSL