Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Fix useRecordContext may return undefined #7495

Merged
merged 1 commit into from
Apr 7, 2022
Merged

[TypeScript] Fix useRecordContext may return undefined #7495

merged 1 commit into from
Apr 7, 2022

Conversation

KoltesDigital
Copy link
Contributor

The doc mentions it but TS doesn't enforce it. I believe it should.

@vercel vercel bot temporarily deployed to Preview – react-admin April 7, 2022 10:28 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin-storybook April 7, 2022 10:28 Inactive
djhi
djhi approved these changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It should probably be done on v4 too

@djhi djhi modified the milestones: 4.0.0-rc.2, 3.19.12 Apr 7, 2022
slax57
slax57 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this submission, this is a good idea indeed!
I'll just wait for the rest of the team to give their approval before merging 🙂

@fzaninotto fzaninotto merged commit c001779 into marmelab:master Apr 7, 2022
@fzaninotto
Copy link
Member

Thanks!

@WiXSL WiXSL mentioned this pull request Apr 7, 2022
Merged
@KoltesDigital
Copy link
Contributor Author

That was quick, thanks :)

@KoltesDigital KoltesDigital deleted the patch-1 branch April 7, 2022 14:17
@meteohr meteohr mentioned this pull request Apr 25, 2022
Closed
@fzaninotto fzaninotto changed the title useRecordContext may return undefined [TypeScript] Fix useRecordContext may return undefined Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

@WiXSL WiXSL WiXSL approved these changes

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.19.12
Development

Successfully merging this pull request may close these issues.
5 participants
@KoltesDigital @fzaninotto @djhi @WiXSL @slax57