Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure All RichTextInput Buttons Update Correctly #7585

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Apr 22, 2022

Fixes #7582

@djhi djhi changed the title Fix RichTextInput Link Button Stay Disabled When Selection Updates Ensure All RichTextInput Buttons Update Correctly Apr 25, 2022
@djhi djhi added the RFR Ready For Review label Apr 25, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin April 25, 2022 09:00 Inactive
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question: do you think we can cover this with tests?

@djhi
Copy link
Collaborator Author

djhi commented Apr 25, 2022

I tried and failed when I implemented this input. Will try again later

@slax57 slax57 merged commit 3f158cb into master Apr 25, 2022
@slax57 slax57 deleted the fix-richtextinput-link-button branch April 25, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default buttons in custom toolbar for RichTextInput not re-rendering
2 participants