Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <Loading> ignores the sx prop #7723

Merged
merged 1 commit into from
May 20, 2022
Merged

Fix <Loading> ignores the sx prop #7723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/ra-ui-materialui/src/layout/Loading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,21 @@
import * as React from 'react';
import { styled } from '@mui/material/styles';
import { SxProps } from '@mui/material';
import PropTypes from 'prop-types';
import CircularProgress from '@mui/material/CircularProgress';
import { useTranslate } from 'ra-core';

export const Loading = props => {
export const Loading = (props: LoadingProps) => {
const {
className,
loadingPrimary = 'ra.page.loading',
loadingSecondary = 'ra.message.loading',
...rest
} = props;

const translate = useTranslate();
return (
<Root className={className}>
<Root className={className} {...rest}>
<div className={LoadingClasses.message}>
<CircularProgress
className={LoadingClasses.icon}
Expand All @@ -37,6 +39,13 @@ Loading.defaultProps = {
loadingSecondary: 'ra.message.loading',
};

export interface LoadingProps {
className?: string;
loadingPrimary?: string;
loadingSecondary?: string;
sx?: SxProps;
}

const PREFIX = 'RaLoading';

export const LoadingClasses = {
Expand Down