Simplify Buttons Props #7750
Merged
Simplify Buttons Props #7750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
approved these changes
May 24, 2022
fzaninotto
reviewed
May 24, 2022
| @@ -38,7 +32,9 @@ export type LocationDescriptor = Partial<Path> & { | |||
| * </Button> | |||
| * | |||
| */ | |||
| export const Button = (props: ButtonProps) => { | |||
| export const Button = <RecordType extends RaRecord = RaRecord>( | |||
There was a problem hiding this comment.
Actually, I failt to see why there is a record prop. This should be handled by the specialized buttons only imo
fzaninotto
reviewed
May 24, 2022
| @@ -102,7 +98,7 @@ export const Button = (props: ButtonProps) => { | |||
| ); | |||
| }; | |||
|
|
|||
| interface Props { | |||
| interface Props<RecordType extends RaRecord = RaRecord> { | |||
There was a problem hiding this comment.
Same, I think this is a breaking change
fzaninotto
reviewed
May 24, 2022
| // May be injected by Toolbar | ||
| record?: RaRecord; | ||
| // May be provided manually | ||
| record?: RecordType; |
There was a problem hiding this comment.
In fact, I fail to see what record does here. It's not even used in the code. This somehow seems to forbid usage of the generic Button outside of a record context, e.g. in a List, a dialog, a sidebar, or a custom page. I wonder why, as Button is purely a UI component.
|
Could you please update the description to explain what problem this PR fixes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.