-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Restructure Translation Documentation #7759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, this looks very fine to me, gj! 🙂
docs/navigation.html
Outdated
<li {% if page.path contains 'Translation.md' %} class="active" {% endif %}><a class="nav-link" href="./Translation.html">Introduction</a></li> | ||
<li {% if page.path contains 'Translating.md' %} class="active" {% endif %}><a class="nav-link" href="./Translating.html">Translating The Interface</a></li> | ||
<li {% if page.path contains 'UserLocale.md' %} class="active" {% endif %}><a class="nav-link" href="./UserLocale.html">User Locale</a></li> | ||
<li {% if page.path contains 'useTranslate.md' %} class="active" {% endif %}><a class="nav-link" href="./useTranslate.html"><code>useTranslate</code></a></li> | ||
<li {% if page.path contains 'useLocaleState.md' %} class="active" {% endif %}><a class="nav-link" href="./useLocaleState.html"><code>useLocaleState</code></a></li> | ||
<li {% if page.path contains 'LocalesMenuButton.md' %} class="active" {% endif %}><a class="nav-link" href="./LocalesMenuButton.html"><code><LocalesMenuButton></code></a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Translating.md'
-> 'TranslationTranslating.md'
And missing 'TranslationSetup.md'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still miss the link to 'TranslationSetup.md' if I'm not mistaken
I'd like to wait for @fzaninotto 's approval before merging this one 🙂 |
Far from perfect yet but that's a start