[Docs] Fix incorrect Javascript term in AutocompleteInput docs #7843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are Javascript objects, not tuples
slax57
reviewed
Jun 16, 2022
| Set the `choices` attribute to determine the options list (with `id`, `name` tuples). | ||
| Set the `choices` attribute to determine the options list (with `id`, `name` objects). |
There was a problem hiding this comment.
I agree those are not "tuples", but to me they aren't objects either. Maybe "fields" or "attributes" would be better?
There was a problem hiding this comment.
They are javascript objects with id and name properties. I agree, the wording is a bit weird.
There was a problem hiding this comment.
I suggest
Set the
choicesattribute to determine the options list. The value must be an array of objects exposing theidandnamefor each choice.
|
Superseded by #7949 |
JinParc
pushed a commit
to JinParc/react-admin
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are Javascript objects, not tuples