Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileInput propTypes for label prop #7869

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ra-ui-materialui/src/input/FileInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ FileInput.propTypes = {
className: PropTypes.string,
id: PropTypes.string,
isRequired: PropTypes.bool,
label: PropTypes.string,
label: PropTypes.oneOfType([PropTypes.string, PropTypes.bool]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, this can also be an element

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you are right. But all other Input component have it declared this way in the propTypes (I've checked).
We should either leave it as is, or change this for all Input components, which goes a bit beyond the scope of this issue. What do you think?

labelMultiple: PropTypes.string,
labelSingle: PropTypes.string,
maxSize: PropTypes.number,
Expand Down