Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SimpleFormIterator inline and sx props #8067

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

fzaninotto
Copy link
Member

Default

image

Inline

image

sx

image

@fzaninotto fzaninotto added the RFR Ready For Review label Aug 11, 2022
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, I'm very pleased with this! 😊

Comment on lines +45 to +56
By using `<SimpleFormIterator inline>`, child inputs apper inline.

```jsx
import { ArrayInput, SimpleFormIterator, DateInput, TextInput } from 'react-admin';

<ArrayInput source="backlinks">
<SimpleFormIterator inline>
<DateInput source="date" />
<TextInput source="url" />
</SimpleFormIterator>
</ArrayInput>
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be even better to add your screenshot here to showcase how this looks like 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SimpleFormIterator component and docs need more love, let's do that later.

@fzaninotto fzaninotto merged commit 860a48e into next Aug 22, 2022
@fzaninotto fzaninotto deleted the simpleformiterator branch August 22, 2022 11:58
@fzaninotto fzaninotto added this to the 4.3 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants