Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simple project UserEdit save usage #8435

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Fix simple project UserEdit save usage #8435

merged 5 commits into from
Nov 29, 2022

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Nov 25, 2022

No description provided.

@fzaninotto
Copy link
Member

What bug does that solve? Wan you add a unit test to prove it?

@slax57
Copy link
Contributor

slax57 commented Nov 28, 2022

It seems to fix the ability to edit an User in the simple demo, which currently (indeed) doesn't work. (I tested it successfully)
But you are correct, we should add this case to the already existing e2e tests to avoid a regression on this in the future.

@WiXSL
Copy link
Contributor Author

WiXSL commented Nov 28, 2022

It seems to fix the ability to edit an User in the simple demo, which currently (indeed) doesn't work. (I tested it successfully) But you are correct, we should add this case to the already existing e2e tests to avoid a regression on this in the future.

Yes, this is what I am fixing.
I'l improve the e2e tests on this

@slax57 slax57 added this to the 4.6 milestone Nov 29, 2022
@slax57 slax57 merged commit 3163326 into master Nov 29, 2022
@slax57 slax57 deleted the fix-simpleform-users branch November 29, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants