Fix incorrect <Ready> page when dynamically load routes with no resources

[smeng9]

As a follow up of feature #7609 under the use case of defining an admin without resources but routes,

There seems to be a bug if additional routes are lazily added to the list of child routes when user navigates in the app.

It triggers a rerender https://github.com/marmelab/react-admin/blame/master/packages/ra-core/src/core/useConfigureAdminRouterFromChildren.tsx#L123 and it incorrectly redirects the user to <Ready /> component

This pull requests adds additional checks similar to https://github.com/marmelab/react-admin/blame/master/packages/ra-core/src/core/useConfigureAdminRouterFromChildren.tsx#L253

[smeng9]

Needs to fix implementation of <Layout> for ra-no-code because if there are any <CustomRoutes> in

react-admin/packages/ra-no-code/src/Admin.tsx

Line 41 in 0796893

const InnerAdmin = (props: AdminProps) => {

the <Ready> with import CSV pop up will not be shown. (which now should be the correct behavior, previous behavior is incorrect.) The <Ready> needs to be moved to <Layout>

[slax57]

Overall your fix seems good, thanks!

But it would be nice to have some tests to prove that it works, and cover this case in the future. Could you add some?

[smeng9]

But it would be nice to have some tests to prove that it works, and cover this case in the future. Could you add some?

I have added a test case so the initial state of lazyRoutes is empty and later is set to a route by useEffect. It triggers a rerender of the useConfigureAdminRouterFromChildren hook.

[slax57]

Also, there is a linter warning in packages/ra-no-code/src/Admin.tsx line 15:

'Ready' is defined but never used

[slax57]

Thanks!