marmelab · slax57 · Dec 20, 2022 · Dec 19, 2022 · Dec 20, 2022 · Dec 20, 2022
diff --git a/docs/Actions.md b/docs/Actions.md
@@ -372,7 +372,7 @@ const ApproveButton = () => {
             },
             onError: (error) => {
                 // failure side effects go here 
-                notify(`Comment approval error: ${error.message}`, { type: 'warning' });
+                notify(`Comment approval error: ${error.message}`, { type: 'error' });
             },
         }
     );
@@ -410,7 +410,7 @@ const ApproveButton = () => {
                 notify('Comment approved');
             },
             onError: (error) => {
-                notify(`Comment approval error: ${error.message}`, { type: 'warning' });
+                notify(`Comment approval error: ${error.message}`, { type: 'error' });
             },
         }
     );
@@ -462,7 +462,7 @@ const ApproveButton = () => {
 -               notify('Comment approved');
 +               notify('Comment approved', { undoable: true });
             },
-            onError: (error) => notify(`Error: ${error.message}`, { type: 'warning' }),
+            onError: (error) => notify(`Error: ${error.message}`, { type: 'error' }),
         }
     );
     return <Button label="Approve" onClick={() => approve()} disabled={isLoading} />;
@@ -504,7 +504,7 @@ const ApproveButton = () => {
                 redirect('/comments');
             })
             .catch((e) => {
-                notify('Error: comment not approved', { type: 'warning' })
+                notify('Error: comment not approved', { type: 'error' })
             })
             .finally(() => {
                 setLoading(false);

diff --git a/docs/Create.md b/docs/Create.md
@@ -241,7 +241,7 @@ The default `onError` function is:
 
 ```jsx
 (error) => {
-    notify(typeof error === 'string' ? error : error.message || 'ra.notification.http_error', { type: 'warning' });
+    notify(typeof error === 'string' ? error : error.message || 'ra.notification.http_error', { type: 'error' });
 }
 ```
 

diff --git a/docs/Datagrid.md b/docs/Datagrid.md
@@ -235,7 +235,7 @@ const CustomResetViewsButton = () => {
                 notify('Posts updated');
                 unselectAll();
             },
-            onError: error => notify('Error: posts not updated', { type: 'warning' }),
+            onError: error => notify('Error: posts not updated', { type: 'error' }),
         }
     );
 
@@ -283,7 +283,7 @@ const CustomResetViewsButton = () => {
                 notify('Posts updated');
                 unselectAll();
             },
-            onError: error => notify('Error: posts not updated', { type: 'warning' }),
+            onError: error => notify('Error: posts not updated', { type: 'error' }),
         }
     );
     const handleClick = () => setOpen(true);
@@ -349,7 +349,7 @@ const CustomResetViewsButton = () => {
 +               notify('Posts updated', { undoable: true }); // the last argument forces the display of 'undo' in the notification
                 unselectAll();
             },
-            onError: error => notify('Error: posts not updated', { type: 'warning' }),
+            onError: error => notify('Error: posts not updated', { type: 'error' }),
 +           mutationMode: 'undoable'
         }
     );

diff --git a/docs/Edit.md b/docs/Edit.md
@@ -390,7 +390,7 @@ The default `onError` function is:
 
 ```jsx
 (error) => {
-    notify(typeof error === 'string' ? error : error.message || 'ra.notification.http_error', { type: 'warning' });
+    notify(typeof error === 'string' ? error : error.message || 'ra.notification.http_error', { type: 'error' });
     if (mutationMode === 'undoable' || mutationMode === 'pessimistic') {
         refresh();
     }

diff --git a/docs/List.md b/docs/List.md
@@ -690,7 +690,7 @@ const PostList = () => {
     const redirect = useRedirect();
 
     const onError = (error) => {
-        notify(`Could not load list: ${error.message}`, { type: 'warning' });
+        notify(`Could not load list: ${error.message}`, { type: 'error' });
         redirect('/dashboard');
     };
 

diff --git a/docs/Show.md b/docs/Show.md
@@ -184,7 +184,7 @@ const PostShow = props => {
     const redirect = useRedirect();
 
     const onError = (error) => {
-        notify(`Could not load post: ${error.message}`, { type: 'warning' });
+        notify(`Could not load post: ${error.message}`, { type: 'error' });
         redirect('/posts');
         refresh();
     };
@@ -205,7 +205,7 @@ The default `onError` function is:
 
 ```jsx
 (error) => {
-    notify('ra.notification.item_doesnt_exist', { type: 'warning' });
+    notify('ra.notification.item_doesnt_exist', { type: 'error' });
     redirect('list', resource);
     refresh();
 }

diff --git a/docs/ShowBase.md b/docs/ShowBase.md
@@ -80,7 +80,7 @@ const PostShow = props => {
     const redirect = useRedirect();
 
     const onError = (error) => {
-        notify(`Could not load post: ${error.message}`, { type: 'warning' });
+        notify(`Could not load post: ${error.message}`, { type: 'error' });
         redirect('/posts');
         refresh();
     };
@@ -101,7 +101,7 @@ The default `onError` function is:
 
 ```jsx
 (error) => {
-    notify('ra.notification.item_doesnt_exist', { type: 'warning' });
+    notify('ra.notification.item_doesnt_exist', { type: 'error' });
     redirect('list', resource);
     refresh();
 }

diff --git a/docs/useNotify.md b/docs/useNotify.md
@@ -31,6 +31,8 @@ The callback takes 2 arguments:
 Here are more examples of `useNotify` calls: 
 
 ```js
+// notify an error
+notify(`This is an error`, { type: 'error' });
 // notify a warning
 notify(`This is a warning`, { type: 'warning' });
 // pass translation arguments

diff --git a/docs/useRefresh.md b/docs/useRefresh.md
@@ -38,7 +38,7 @@ const DeleteCommentButton = () => {
                 notify('Comment deleted');
             },
             onError: (error) => {
-                notify(`Comment deletion error: ${error.message}`, { type: 'warning' });
+                notify(`Comment deletion error: ${error.message}`, { type: 'error' });
             },
         }
     );

diff --git a/docs/useShowController.md b/docs/useShowController.md
@@ -75,7 +75,7 @@ const PostShow = props => {
     const redirect = useRedirect();
 
     const onError = (error) => {
-        notify(`Could not load post: ${error.message}`, { type: 'warning' });
+        notify(`Could not load post: ${error.message}`, { type: 'error' });
         redirect('/posts');
         refresh();
     };
@@ -111,7 +111,7 @@ The default `onError` function is:
 
 ```js
 (error) => {
-    notify('ra.notification.item_doesnt_exist', { type: 'warning' });
+    notify('ra.notification.item_doesnt_exist', { type: 'error' });
     redirect('list', resource);
     refresh();
 }

diff --git a/examples/demo/src/layout/Login.tsx b/examples/demo/src/layout/Login.tsx
@@ -44,7 +44,7 @@ const Login = () => {
                     ? 'ra.auth.sign_in_error'
                     : error.message,
                 {
-                    type: 'warning',
+                    type: 'error',
                     messageArgs: {
                         _:
                             typeof error === 'string'

diff --git a/examples/demo/src/reviews/AcceptButton.tsx b/examples/demo/src/reviews/AcceptButton.tsx
@@ -34,7 +34,7 @@ const AcceptButton = () => {
             },
             onError: () => {
                 notify('resources.reviews.notification.approved_error', {
-                    type: 'warning',
+                    type: 'error',
                 });
             },
         }

diff --git a/examples/demo/src/reviews/BulkAcceptButton.tsx b/examples/demo/src/reviews/BulkAcceptButton.tsx
@@ -31,7 +31,7 @@ const BulkAcceptButton = () => {
             },
             onError: () => {
                 notify('resources.reviews.notification.approved_error', {
-                    type: 'warning',
+                    type: 'error',
                 });
             },
         }

diff --git a/examples/demo/src/reviews/BulkRejectButton.tsx b/examples/demo/src/reviews/BulkRejectButton.tsx
@@ -31,7 +31,7 @@ const BulkRejectButton = () => {
             },
             onError: () => {
                 notify('resources.reviews.notification.approved_error', {
-                    type: 'warning',
+                    type: 'error',
                 });
             },
         }

diff --git a/examples/demo/src/reviews/RejectButton.tsx b/examples/demo/src/reviews/RejectButton.tsx
@@ -34,7 +34,7 @@ const RejectButton = () => {
             },
             onError: () => {
                 notify('resources.reviews.notification.rejected_error', {
-                    type: 'warning',
+                    type: 'error',
                 });
             },
         }

diff --git a/examples/simple/src/posts/ResetViewsButton.tsx b/examples/simple/src/posts/ResetViewsButton.tsx
@@ -23,7 +23,7 @@ const ResetViewsButton = ({ resource, selectedIds }) => {
                     typeof error === 'string'
                         ? error
                         : error.message || 'ra.notification.http_error',
-                    { type: 'warning' }
+                    { type: 'error' }
                 ),
             mutationMode: 'undoable',
         }

diff --git a/packages/ra-core/src/auth/Authenticated.spec.tsx b/packages/ra-core/src/auth/Authenticated.spec.tsx
@@ -91,7 +91,7 @@ describe('<Authenticated>', () => {
             expect(notificationsSpy).toEqual([
                 {
                     message: 'ra.auth.auth_check_error',
-                    type: 'warning',
+                    type: 'error',
                     notificationOptions: {},
                 },
             ]);

diff --git a/packages/ra-core/src/auth/useAuthenticated.spec.tsx b/packages/ra-core/src/auth/useAuthenticated.spec.tsx
@@ -138,7 +138,7 @@ describe('useAuthenticated', () => {
             expect(notificationsSpy).toEqual([
                 {
                     message: 'ra.auth.auth_check_error',
-                    type: 'warning',
+                    type: 'error',
                     notificationOptions: {},
                 },
             ]);

diff --git a/packages/ra-core/src/auth/useCheckAuth.ts b/packages/ra-core/src/auth/useCheckAuth.ts
@@ -72,7 +72,7 @@ export const useCheckAuth = (): CheckAuth => {
                     !shouldSkipNotify &&
                         notify(
                             getErrorMessage(error, 'ra.auth.auth_check_error'),
-                            { type: 'warning' }
+                            { type: 'error' }
                         );
                 }
                 throw error;

diff --git a/packages/ra-core/src/auth/useLogoutIfAccessDenied.ts b/packages/ra-core/src/auth/useLogoutIfAccessDenied.ts
@@ -32,7 +32,7 @@ let timer;
  *         dataProvider.getOne('secret', { id: 123 })
  *             .catch(error => {
  *                  logoutIfAccessDenied(error);
- *                  notify('server error', 'warning');
+ *                  notify('server error',  { type: 'error' });
  *              })
  *     }, []);
  *     // ...
@@ -84,15 +84,15 @@ const useLogoutIfAccessDenied = (): LogoutIfAccessDenied => {
                                             e,
                                             'ra.notification.logged_out'
                                         ),
-                                        { type: 'warning' }
+                                        { type: 'error' }
                                     );
                                 } else {
                                     notify(
                                         getErrorMessage(
                                             e,
                                             'ra.notification.not_authorized'
                                         ),
-                                        { type: 'warning' }
+                                        { type: 'error' }
                                     );
                                 }
                             })

diff --git a/packages/ra-core/src/controller/button/useDeleteWithConfirmController.tsx b/packages/ra-core/src/controller/button/useDeleteWithConfirmController.tsx
@@ -120,7 +120,7 @@ const useDeleteWithConfirmController = <RecordType extends RaRecord = any>(
                                 ? error
                                 : error.message || 'ra.notification.http_error',
                             {
-                                type: 'warning',
+                                type: 'error',
                                 messageArgs: {
                                     _:
                                         typeof error === 'string'

diff --git a/packages/ra-core/src/controller/button/useDeleteWithUndoController.tsx b/packages/ra-core/src/controller/button/useDeleteWithUndoController.tsx
@@ -85,7 +85,7 @@ const useDeleteWithUndoController = <RecordType extends RaRecord = any>(
                                 ? error
                                 : error.message || 'ra.notification.http_error',
                             {
-                                type: 'warning',
+                                type: 'error',
                                 messageArgs: {
                                     _:
                                         typeof error === 'string'

diff --git a/packages/ra-core/src/controller/create/useCreateController.spec.tsx b/packages/ra-core/src/controller/create/useCreateController.spec.tsx
@@ -158,7 +158,7 @@ describe('useCreateController', () => {
         expect(notificationsSpy).toEqual([
             {
                 message: 'not good',
-                type: 'warning',
+                type: 'error',
                 notificationOptions: { messageArgs: { _: 'not good' } },
             },
         ]);

diff --git a/packages/ra-core/src/controller/create/useCreateController.ts b/packages/ra-core/src/controller/create/useCreateController.ts
@@ -126,7 +126,7 @@ export const useCreateController = <
                                           : error.message ||
                                                 'ra.notification.http_error',
                                       {
-                                          type: 'warning',
+                                          type: 'error',
                                           messageArgs: {
                                               _:
                                                   typeof error === 'string'

diff --git a/packages/ra-core/src/controller/edit/useEditController.spec.tsx b/packages/ra-core/src/controller/edit/useEditController.spec.tsx
@@ -687,7 +687,7 @@ describe('useEditController', () => {
         expect(notificationsSpy).toEqual([
             {
                 message: 'not good',
-                type: 'warning',
+                type: 'error',
                 notificationOptions: { messageArgs: { _: 'not good' } },
             },
         ]);

diff --git a/packages/ra-core/src/controller/edit/useEditController.ts b/packages/ra-core/src/controller/edit/useEditController.ts
@@ -87,7 +87,7 @@ export const useEditController = <
         {
             onError: () => {
                 notify('ra.notification.item_doesnt_exist', {
-                    type: 'warning',
+                    type: 'error',
                 });
                 redirect('list', resource);
                 refresh();
@@ -181,7 +181,7 @@ export const useEditController = <
                                           : error.message ||
                                                 'ra.notification.http_error',
                                       {
-                                          type: 'warning',
+                                          type: 'error',
                                           messageArgs: {
                                               _:
                                                   typeof error === 'string'

diff --git a/packages/ra-core/src/controller/field/useReferenceArrayFieldController.ts b/packages/ra-core/src/controller/field/useReferenceArrayFieldController.ts
@@ -74,7 +74,7 @@ export const useReferenceArrayFieldController = (
                         ? error
                         : error.message || 'ra.notification.http_error',
                     {
-                        type: 'warning',
+                        type: 'error',
                         messageArgs: {
                             _:
                                 typeof error === 'string'

diff --git a/packages/ra-core/src/controller/field/useReferenceManyFieldController.ts b/packages/ra-core/src/controller/field/useReferenceManyFieldController.ts
@@ -164,7 +164,7 @@ export const useReferenceManyFieldController = (
                         ? error
                         : error.message || 'ra.notification.http_error',
                     {
-                        type: 'warning',
+                        type: 'error',
                         messageArgs: {
                             _:
                                 typeof error === 'string'

diff --git a/packages/ra-core/src/controller/field/useReferenceOneFieldController.tsx b/packages/ra-core/src/controller/field/useReferenceOneFieldController.tsx
@@ -81,7 +81,7 @@ export const useReferenceOneFieldController = <
                         ? error
                         : error.message || 'ra.notification.http_error',
                     {
-                        type: 'warning',
+                        type: 'error',
                         messageArgs: {
                             _:
                                 typeof error === 'string'

diff --git a/packages/ra-core/src/controller/list/useListController.ts b/packages/ra-core/src/controller/list/useListController.ts
@@ -98,7 +98,7 @@ export const useListController = <RecordType extends RaRecord = any>(
             retry: false,
             onError: error =>
                 notify(error?.message || 'ra.notification.http_error', {
-                    type: 'warning',
+                    type: 'error',
                     messageArgs: {
                         _: error?.message,
                     },

diff --git a/packages/ra-core/src/controller/show/useShowController.ts b/packages/ra-core/src/controller/show/useShowController.ts
@@ -68,7 +68,7 @@ export const useShowController = <RecordType extends RaRecord = any>(
         {
             onError: () => {
                 notify('ra.notification.item_doesnt_exist', {
-                    type: 'warning',
+                    type: 'error',
                 });
                 redirect('list', resource);
                 refresh();

diff --git a/packages/ra-core/src/form/useNotifyIsFormInvalid.ts b/packages/ra-core/src/form/useNotifyIsFormInvalid.ts
@@ -23,7 +23,7 @@ export const useNotifyIsFormInvalid = (control?: Control) => {
             submitCountRef.current = submitCount;
 
             if (Object.keys(errors).length > 0) {
-                notify('ra.message.invalid_form', { type: 'warning' });
+                notify('ra.message.invalid_form', { type: 'error' });
             }
         }
     }, [errors, submitCount, notify]);

diff --git a/packages/ra-core/src/i18n/I18nContextProvider.tsx b/packages/ra-core/src/i18n/I18nContextProvider.tsx
@@ -39,7 +39,7 @@ export const I18nContextProvider = ({
                 })
                 .catch(error => {
                     setInitialized(true);
-                    notify('ra.notification.i18n_error', { type: 'warning' });
+                    notify('ra.notification.i18n_error', { type: 'error' });
                     console.error(error);
                 });
         } else {
-Original file line number
+Diff line change
@@ Expand Up / @@ -241,7 +241,7 @@ The default `onError` function is: @@
     ```jsx
     (error) => {
-        notify(typeof error === 'string' ? error : error.message || 'ra.notification.http_error', { type: 'warning' });
+        notify(typeof error === 'string' ? error : error.message || 'ra.notification.http_error', { type: 'error' });
     }
     ```
@@ Expand Down @@