Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: highlight error in red when form is submitted #8627

Closed
wants to merge 1 commit into from

Conversation

sumithmano
Copy link

If the checkbox is required by the form but is touched then upon submit validation error is displayed, but not highlighted in red color.

If the checkbox is required by the form but is touched then upon submit validation error is displayed, but not highlighted in red color.
@fzaninotto
Copy link
Member

I'm sorry, I don't understand the problem. Would you mind elaborating a bit, or even better, adding a screencast of what happens and what you'd like instead?

@sumithmano
Copy link
Author

If CheckboxGroupInput is required in a form and submit form button is triggered without touching the component.
then the error helperText is not highlighted in error(red) color.
Screenshot 2023-02-14 at 11 13 19 AM

@fzaninotto
Copy link
Member

Thanks for the description, now I understand better.

Your PR has linter warnings and misses a storybook to be able to test it. To push this fix forward, I opened a new PR #8652 with these changes. That PR supersedes yours.

@fzaninotto fzaninotto closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants