Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meta prop to ExportButton and BulkExportButton #8636

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Add meta prop to ExportButton and BulkExportButton #8636

merged 4 commits into from
Feb 13, 2023

Conversation

fkowal
Copy link
Contributor

@fkowal fkowal commented Feb 9, 2023 •
edited by slax57
Loading

Fix #8635

@fzaninotto
Copy link
Member

Thanks! As this is a new feature, please open the PR against next, and include documentation and tests

@fkowal fkowal changed the base branch from master to next February 9, 2023 09:50
@fkowal
Copy link
Contributor Author

fkowal commented Feb 9, 2023

specs added, as far as documentation that seems like an overkill imho

@fkowal fkowal force-pushed the feature/export_with_meta branch from a7da4fb to 7476df8 Compare February 9, 2023 10:50
@fzaninotto
Copy link
Member

Documentation is never overkill ;)

Please add a mention of that new prop in https://marmelab.com/react-admin/Buttons.html#exportbutton

@fkowal
Copy link
Contributor Author

fkowal commented Feb 10, 2023

done

slax57
slax57 requested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this, everything looks good to me 🙂

packages/ra-ui-materialui/src/button/ExportButton.tsx Outdated
@@ -13,6 +13,7 @@ import {
useResourceContext,
} from 'ra-core';
import { Button, ButtonProps } from './Button';
import { UseQueryOptions } from 'react-query';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter warning on this line:
'UseQueryOptions' is defined but never used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned up

@slax57 slax57 added this to the 4.8.0 milestone Feb 13, 2023
@slax57 slax57 merged commit 455c2d3 into marmelab:next Feb 13, 2023
@slax57
Copy link
Contributor

slax57 commented Feb 13, 2023

Thanks!

@slax57 slax57 mentioned this pull request Feb 13, 2023
Closed
@slax57 slax57 changed the title enable passing meta to ExportButton/BulkExportButton dataProvider #8635 Add meta prop to ExportButton and BulkExportButton Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fkowal @fzaninotto @slax57