-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve AppBar Customization #8681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Switching to RFR |
* [<`Title>`](./Title.md) | ||
* [<`TitlePortal>`](./AppBar.md#children) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Found a typo, I'm not sure if this is an issue
<`Title>` to `<Title>`
<`TitlePortal>` to `<TitlePortal>`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, can you open a PR to fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
Problem
Adding new buttons or a search engine to the AppBar is cumbersome
Solution
<TitlePortal>
component to avoid copy/pasting a large<Typography>
from the doctoolbar
prop to let users override the default toolbaralwaysOn
prop to facilitate always on toolbars (and deprecatecomponent
prop)<Title>
doesn't work without routingAppBar
doc chapterTitle
doc chapter<AppBar>
usage examples in the doc and demosResulting API
To add buttons to the app bar, you can use the
<AppBar>
children
prop.For instance, to add
<ToggleThemeButton>
: