Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the to prop in memoization check of <CreateButton> and <ShowButton> #8741

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Include the to prop in memoization check of <CreateButton> and <ShowButton> #8741

merged 1 commit into from
Mar 17, 2023

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Mar 17, 2023

Fixes #8671

@djhi djhi added the RFR Ready For Review label Mar 17, 2023
@slax57 slax57 added this to the 4.8.4 milestone Mar 17, 2023
@slax57 slax57 merged commit 0d4e128 into master Mar 17, 2023
@slax57 slax57 deleted the better-buttons-memo branch March 17, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.8.4
Development

Successfully merging this pull request may close these issues.

[Regression] CreateButton and ShowButton don't update on 'to' prop change
2 participants
@djhi @slax57