Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <DeleteButton> doesn't allow to override the text color #9060

Merged
merged 7 commits into from
Jul 3, 2023
Merged

Fix <DeleteButton> doesn't allow to override the text color #9060

merged 7 commits into from
Jul 3, 2023

Conversation

adguernier
Copy link
Contributor

Fix #9050

@adguernier adguernier added the WIP Work In Progress label Jun 28, 2023
@adguernier adguernier added RFR Ready For Review and removed WIP Work In Progress labels Jul 3, 2023
slax57
slax57 requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, the code looks good IMO

@slax57 slax57 requested a review from djhi July 3, 2023 10:03
@slax57 slax57 added this to the 4.11.5 milestone Jul 3, 2023
@slax57 slax57 merged commit 50c1322 into master Jul 3, 2023
@slax57 slax57 deleted the 9050-fix-delete-button-style branch July 3, 2023 12:07
@slax57 slax57 modified the milestones: 4.11.5, 4.12.0 Jul 3, 2023
@slax57 slax57 changed the title Fix delete button style Fix <DeleteButton> doesn't allow to override the text color Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

@djhi djhi Awaiting requested review from djhi

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

DeleteButton styling
3 participants
@adguernier @djhi @slax57