RA-OSS-14 - FilterLiveSearch does not clear its value #9128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: passy4ucj <ojinnnakapascal@gmail.com> Co-authored-by: Pascal Ojinnaka <56399504+passy4ucj@users.noreply.github.com>
slax57
requested changes
Jul 25, 2023
There was a problem hiding this comment.
Thank you for your contribution.
First of all, please mention the issue your PR is aiming at fixing (in this case #9106 I believe)
Also, please include a test, or a way to prove that the fix works.
Lastly, there is a linter warning at line 55.
Can you please configure your IDE to raise these linter warnings before pushing the code?
Thanks a lot.
Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: passy4ucj <ojinnnakapascal@gmail.com> Co-authored-by: Pascal Ojinnaka <56399504+passy4ucj@users.noreply.github.com>
|
Still not good. We can actually see in the screencast you shared that the filter gets cleared before you click on the reset button. |
|
Superseded by #9149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the GitStart Ticket for this pull request: RA-OSS-14
ISSUE
https://www.loom.com/share/5ea0150d4def490dba21c8d8bf54c7a1?sid=29b3714a-8f94-4d9a-9807-8c2514f3e852
Happy hacking! 🎉
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.